How's It Looking?

Kamikaze_Badger · October 31, 2004

Ok, almost done with the OS Stresser(I'll be porting it over to Assembly for burning the CPU). Anyone mind telling me what I need to improve upon, other than the loops?

/* Here's our main part of the program. Functions, etc, are in here...
** This is all under the GNU GPL. You may modify it in any way that pleases you
** It works by stressing out the OS right now. I'll get to porting it over
** to Assembly after I get more fluent in C++. */

#include <iostream.h>
#include "Defs.h"

using namespace std;

double dblTrillion = "1000000000000";

int main();
{
    cout << "Welcome to the Burn-A-Natar 3000! Type in anything to" << endl; <<
    "continue, or \"exit\" to quit: " << endl; <<;
    
    cin >> INTRO_ANSWER;
    
    if (INTRO_ANSWER == INTRO_COMPARE)
     {
         //Going to use pseudo code for now, as my net is down due to worms,
         //and I can't remember the proper usage of do-while loops
         
         do 
            ( int z;
             z = lnTrillFunc ( .0000000000000000002 , .0000000000000000002 );
             cout << "We're at: " << z << " right now."; )
             
         while ( z != dblTrillion )
     }
     
     else
     
         {
             cout << "Goodbye!";
             
                 return(0);
         }
     }
         

   
    double dblTrillFunc ( double dblDeciOne , double dblDeciTwo );
  
  {
      long lnTrillResult;
      
      /* double dblDeciOne(.000000000000000000002);
      double dblDeciTwo(.000000000000000000002); */
      
      lnTrillResult = ( dblDeciOne * dblDeciTwo );
      
      return(lnTrillResult);
  }
  
  
  
  
  /* Credits:
      
     Emily, for being an everlasting pillar of support and love. *hug*
     AntiOnline members, for helping me out with all of this project.
     Bjorne Stoustruppe, for making this programming language. =)
     Everyone at the OCC, for being my friends and helping me out with life issues
     Mike McGrath, for writing C++ in Easy Steps, the best C++ book EVAR!
     Dad, for your support in my modding and programming.
     Everyone at Bloodshed, for making Dev-C++, the best open source C/++ IDE.
     Anyone else I missed, thanks anyhow! You've all made this program possible. */

Defs.h:

#define INTRO_ANSWER
#define INTRO_COMPARE "exit"

markiemrboo · October 31, 2004

first looks... it won't compile.

1)

cin >> INTRO_ANSWER;

INTRO_ANSWER should be a variable and not a preprocessor macro.

2)

"100000000" or whatever it is shouldn't be enclosed in "'s, since that indicates a string, or array of characters. It's likely too big of a number anyhow..

3)

main(); shouldn't have the ; at the end

4)

endl; shouldn't have ; at the end either

5) the pseudo-code isn't really pseudo code at all

do {

} while (condition); the { are ( and ) in your code.

6)

<< endl; <<;

no need for that << at the end

7)

int z; should be moved outside the loop I think.

8)

long lnTrillResult should be a double by the looks of things

9)

some nice indenting wouldn't go a miss

10)

Defs.h should include the function prototype for dblTrillFunc or whatever it is Won't stop it compiling, however... you seem to have changed the name along the lines as you're calling it lnTrillFunc in the loop.

11)

int z shouldn't even be an int, it should be a double.. since that's what your function returns

INTRO_ANSWER == INTRO_COMPARE should be != INTRO_COMPARE probly too..

EDIT: Oh yeah and it shouldn't actually be INTRO_ANSWER == INTRO_COMPARE or whatever at all, because that would be comparing pointers, which are unlikely to ever be the same unless you're special you'll have to use something like strcmp.. there's probably other better functions I don't know about though.

UPDATE: Had a quick go in C. Hows this?

#include <stdio.h>
#include <assert.h>
#include <string.h>

#define INPUTBUFFER 5

double MultiplyDoubles(double, double);

int main(void) {
       char *input;
       double z = 0, dblTrill = 100000;

       input = (char *)malloc(sizeof(char) * INPUTBUFFER);
       assert(input != NULL);
       memset(input, 0, INPUTBUFFER);

       printf("Welcome to the Burn-A-Natar 3000!\n");
       printf("Type in anything to continue, or \"exit\" to quit\n");
       printf("> ");

       fgets(input, INPUTBUFFER, stdin);
       if (strcmp(input, "exit") == 0) {
               printf("Exit\n");
       } else {
               while (z < dblTrill) {
                       z = z + MultiplyDoubles(0.00002, 0.00002);
                       printf("z is currently at: %f\n", z);
               }
       }

       return 0;
}

double MultiplyDoubles(double dblOne, double dblTwo) {
       return (dblOne * dblTwo);
}

The strcmp is a little rough, "exit" and whatever was in input wouldn't compare correctly if the input buffer was bigger than 4 character + \0 (5). Other than that it seems to run: (increased from 0.00002 to 0.002 for example)

(mrboo|bone)/home/mrboo$ ./mburn

Welcome to the Burn-A-Natar 3000!

Type in anything to continue, or "exit" to quit

>

z is currently at: 0.000004

z is currently at: 0.000008

z is currently at: 0.000012

z is currently at: 0.000016

z is currently at: 0.000020

z is currently at: 0.000024

z is currently at: 0.000028

z is currently at: 0.000032

z is currently at: 0.000036

z is currently at: 0.000040

z is currently at: 0.000044

z is currently at: 0.000048

z is currently at: 0.000052

z is currently at: 0.000056

z is currently at: 0.000060

z is currently at: 0.000064

z is currently at: 0.000068

z is currently at: 0.000072

z is currently at: 0.000076

z is currently at: 0.000080

z is currently at: 0.000084

z is currently at: 0.000088

z is currently at: 0.000092

z is currently at: 0.000096

z is currently at: 0.000100

*cough* I know nothing of threads for Windows - or in general really - so I won't post the code unless someone really wants to see. I just made it print z's current value from z once every second, so that the majority of the CPU time doesn't end up in printf (alot quicker on a poor 133). Back at 0.00002 * 0.00002:

(mrboo|bone)/home/mrboo$ ./mburn

Welcome to the Burn-A-Natar 3000!

Type in anything to continue, or "exit" to quit

>

INFO: Currently at: 0.0000200308